Repository navigation
fix(render): align container Chrome with the CLI - #5338
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use
chrome-headless-shell@152.0.7977.30in the Cloud Run and regression-test images, matching the CLI's pinned Chrome build. Gradient text now includes child glyphs when a transform creates a separate paint layer.Why
Chrome 148 omits the transformed child's text from a
background-clip: textmask. The same HTML paints both lines with Chrome 152. The existing chat fixture also loses its final gradient heading with 148, so its MP4 baseline is regenerated with 152.Related work
Fixes #5117. Thanks to the reporter for the reproduction and Arcade fork patch. #5207 covers gradient contrast inspection and is already merged; this change addresses the renderer image pins. The Cloud Run BeginFrame build contract from #2817 remains enforced.
How
Change both exact browser pins together, add a one-second nested-composition regression with identical direct and transformed text, and register it in the shard schedule. The fixture's compiled snapshot and MP4 are uploaded through Git LFS, along with the regenerated chat MP4. The chat source and compiled snapshot stay unchanged.
Test plan
Dockerfile.testfor Linux/amd64 with the new pin and build the Cloud Runbeginframe-contracttarget. Its production Chrome flags produce a PNG throughHeadlessExperimental.beginFrame; the packaged browser also paints the layered gradient text.Local corpus validation uses Linux/amd64 emulation on macOS. Slow public S3, GSAP, and font downloads were cached through a test-only preload using verified original bytes; fixture URLs, sources, and quality gates are unchanged. Stalled captures were retried sequentially.
PRODUCER_LOW_MEMORY_MODE=falseavoids the local 8 GiB VM's automatic low-memory routing; the existing BeginFrame capability probe still controls fallback. Cloud Run validation covers the image's build contract rather than a deployment.